Old explosion rooted out, work in progress

[cuberound]

About the pull request

removing old bad code is good, only balance part is mortar shells and exploding magazines and ammo boxes (test the magazines they are changed the most I think and ammo boxes) rest is unused but plase go thrue it as I might have done some mistake. the numbers can be adjusted, especily the mortar

Explain why it's good for the game

Testing Photographs and Procedure

direct incen shell should do less harm then HE shell and old bad code removing is good

Changelog

🆑
balance: HE mortar shell is 240 power with 34 falloff incen 200 power with 33 falloff
fix: all explosions use "new" explosion code directly
/:cl:

[github-actions]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

[Drulikar]

stale exempt until reviewed

[Drulikar]

This PR shouldn't be actually changing any resulting explosion values. Just run in debugger, turn on attack logging, and adv proc call each old explosion to evaluate the resulting cell_explosion any you need to determine the new values for. For loc, just mark some turf as your marked datum (don't care about the missing cause_data):

For example you removed
explosion(projectile.loc, -1, 2, 4, 5, , , ,projectile.weapon_cause_data)
replacing it with
cell_explosion(projectile.loc, 200, 32, EXPLOSION_FALLOFF_SHAPE_LINEAR, null, projectile.weapon_cause_data)
When the old explosion actually resulted in this:

[Drulikar]

Why is this necessary? It just looks way less interesting now. Did you intend this to be just a part of the cell_explosion proc and forgot?

[github-actions]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself