Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes delay when failing to move #6498

Closed
wants to merge 2 commits into from

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented Jun 17, 2024

About the pull request

Remove the delay when you fail to move (aka move into a dense object)
(there is still a minimal delay to reduce spam on code)

Explain why it's good for the game

Makes moving a lot smoother, currently it just feels like your clicks are getting eaten which gets worse with lower movement speeds and higher ping (what is happening is you get full move delay if you move into a dense object so if you mistime it looks like your clicks get eaten)

Testing Photographs and Procedure

Both videos are me holding the W key and pressing the D key rapidly

Current:

2024-06-17.21-15-03.mp4

After the PR:

2024-06-17.21-17-19.mp4

Changelog

🆑
qol: Removed delay when failing to move
fix: You longer take damage from shrapnel when failing to move
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Jun 17, 2024
@iloveloopers
Copy link
Contributor

how does this affect bodyblocking?

@Git-Nivrak
Copy link
Contributor Author

how does this affect bodyblocking?

Needs to be TMed to find out

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jun 17, 2024
@Git-Nivrak
Copy link
Contributor Author

From some wacky testing it looks like it makes it impossible to bodyblock mobs that a bigger than you (mobs that you can't push)
This can probably be fixed but I am not sure how much of a bad thing it is

@Git-Nivrak
Copy link
Contributor Author

Actually it is probably a bad thing since it allows you to push things at full speed

@Drulikar
Copy link
Contributor

I am not inclined this should change. Nor does it eliminate the possibility of inputs being dropped in the situation its explicitly trying to improve. Waiting on other maintainer feedback before just closing however.

@Butlerblock
Copy link

In a similar question to body blocking, does this rapidly speed-up the rate at which non-anchored objects are pushed? This could inadvertently be much more powerful for xenos. If I had a suggestion, it might be be more appropriate to only remove the delay if the user pushes against a non-anchored object.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 27, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 3, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jul 8, 2024
@Git-Nivrak Git-Nivrak closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Merge Conflict PR can't be merged because it touched too much code Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants