Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds complete vent system to Fiorina #6500

Closed
wants to merge 19 commits into from

Conversation

HeresKozmos
Copy link
Contributor

About the pull request

Adds a complete vent system to Fiorina.

Explain why it's good for the game

Unlike most other maps, Fiorina doesn't have a vent system at all; which this fixes and brings it in line with the other maps.

To stop you from going from one edge of the map to the other, each major area has its own closed loop vent system; for example you can only enter a vent inside of Engineering and exit from somewhere else inside Engineering. I've added grates where possible to help with identifying and locating pipes so you don't have to rip up the entire floor.

The main point of this PR is to bring it up to the same level that large maps like Chance's Claim or New Varadero have when it comes to vent availability.

Testing Photographs and Procedure

This is an image of Fiorina with no turf, you can zoom in and follow the pipes to look at where they go to and from:
Fiorina Vent System - Turfless

Changelog

🆑
maptweak: Adds closed loop vent systems to each major area in Fiorina.
maptweak: Changes some floors to include grates to make pipes visible/easier to locate.
maptweak: Moved a few minor map props to make space for vents a short distance from their original spots.
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Jun 17, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 25, 2024
@Drulikar Drulikar added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jun 27, 2024
@Drulikar
Copy link
Contributor

Stale exempt until mapping reviewed.

@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jun 27, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 10, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
image
image
image
image

Only one entrance per vent. You're using two threeway's for no raisin!!!

image
Missing pipe

image
Don't run pipes under walls

image
You also has a lot of redundancy in your pipe system, tldr. it looping into itself and having several way to reach the same spot. It's fine to a certain degree, but I'd say cut a few of these pathways and in some other areas.

One scrubber and one vent pump per room is the standard, look at the Almayer as an example. Of course, is the room massive you can add in another set of two and so forth.

@Nanu308 Nanu308 marked this pull request as draft July 18, 2024 00:28
@Nanu308 Nanu308 removed the Stale Exempt PR can't go stale label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants