Makes worn_id a private var #6505
Conversation
github-actions
bot
added
the
Missing Changelog
| @@ -369,6 +369,7 @@ | |||
|
|
|||
| //gets ID card object from special clothes slot or null. | |||
| /mob/living/carbon/human/proc/get_idcard() | |||
| RETURN_TYPE(/obj/item) | |||
There was a problem hiding this comment.
Wouldn't this be more correct as /obj/item/card/id
code/_onclick/hud/human.dm
Outdated
There was a problem hiding this comment.
It is not correct that the changes here are returning the ID card. It just makes it so if say you have your ID in a wallet, the wallet will disappear because somereason you're having it directly search for the ID card:
Think of wear_id merely as the inventory SLOT. It was just merely incorrect before that things would assume the only thing that could be slotted was an ID card.
|
In general I just really don't think this is worth doing. There's nothing special about why this inventory slot needs to be treated differently than any other inventory slot. It was just an incorrect assumption that code made before that the only thing that could be slotted was of the type |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Title
Explain why it's good for the game
Stops #6411 from happening again