Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuclear Authentication Disks reduce Nuclear Weapon decryption time. #6511

Closed

Conversation

blackdragonTOW
Copy link
Contributor

@blackdragonTOW blackdragonTOW commented Jun 19, 2024

About the pull request

Adds a simple 30% reduction in what ever decryption time is left when we use a Nuclear Authentication Disk on a nuke.

Note: Has no effect on the admin spawned nuke which does not have a decryption timer.

Explain why it's good for the game

Presently our maps have Nuclear Authentication Disks, and when found it's treated with some semblance of gravity, but in actuality they do nothing. This rewards finding such an important object and in the occasion that the disk is found and the End Game for the round is also a decryption nuke.

Testing Photographs and Procedure

Tested with all listed fail states contained within /obj/structure/machinery/nuclearbomb/tech/attackby()

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Nuclear Authentication Disks now reduce remaining decryption time by 30%.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jun 19, 2024
@vero5123
Copy link
Contributor

lord, you need to do early returns man.

@blackdragonTOW
Copy link
Contributor Author

lord, you need to do early returns man.

Yeahhhh, still learning, tried it another way that should be easier to read.

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on the discord; maybe tie this instead into self destruction. E.g. 50% faster or just instant SD or something. Already xenos struggle to get to a nuke fast enough. If marines are able to manage to get objectives to get a SD online, then this would encourage people to actually go for that; whereas now SD is really rare.

Ultimately find a way to not have the 10 minute time be variable.

@Drulikar Drulikar marked this pull request as draft June 19, 2024 23:52
@Steelpoint
Copy link
Contributor

Maybe the disk allows you to set a custom detonation timer? Instead of a flat 60 seconds, you can set it to detonate either instantly or up to several minutes slower than normal?

@blackdragonTOW
Copy link
Contributor Author

Maybe the disk allows you to set a custom detonation timer? Instead of a flat 60 seconds, you can set it to detonate either instantly or up to several minutes slower than normal?

Likely would get shotdown faster than just the decrypt timer. Marines wont set it longer than 60s and making it shorter than 60s would be "unfair" according to our resident xeno experts.

Regardless changing this to making the reactors behave differently during SD is way off Theme for what this sets out to do so I'll just kill it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants