Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swaps MOTD and TM load order in chatbox, nukes no admin event message #6534

Merged
merged 3 commits into from
Jul 6, 2024

Conversation

GrrrKitten
Copy link
Contributor

@GrrrKitten GrrrKitten commented Jun 22, 2024

About the pull request

Removes the
image
message from showing up

Also swaps MOTD and TM message so people actually see the MOTD instead of 10 TM's

Explain why it's good for the game

pt 1) if there isnt a message set for admin events, you can easily intuit that admins arent running an event or they didnt think it was necessary

pt 2) people werent seeing the MOTD cause it would get pushed up by 10 tm's, meaning people weren't seeing potentially important info

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
ui: Swaps TM and MOTD order so that people actually see the MOTD
admin: Removes the message for when no event info is input
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Admin Make things harder for admins labels Jun 22, 2024
@GrrrKitten GrrrKitten changed the title Better-MOTD Swaps MOTD and TM load order in chatbox, nukes no admin event message Jun 22, 2024
@GrrrKitten GrrrKitten marked this pull request as ready for review June 22, 2024 17:13
@GrrrKitten GrrrKitten requested a review from fira as a code owner June 22, 2024 17:13
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't do what you want, you need to change the order they're sent in /mob/new_player/proc/lobby()

@harryob harryob marked this pull request as draft June 23, 2024 16:43
@GrrrKitten GrrrKitten marked this pull request as ready for review June 23, 2024 18:22
@GrrrKitten GrrrKitten requested a review from harryob June 23, 2024 18:22
@harryob harryob added this pull request to the merge queue Jul 6, 2024
Merged via the queue into cmss13-devs:master with commit d15dc88 Jul 6, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants