Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burrower burrow transparency #6550

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

Unknownity
Copy link
Contributor

@Unknownity Unknownity commented Jun 24, 2024

About the pull request

Burrower used to be completely invisible to the user when burrowed, this was suddenly changed some time ago (idk when, I was away) and made the Burrower completely visible as if he isnt underground.

This PR will bring back the immersion and improve it. Now the Burrower becomes partly transparent while burrowed as a visual indication that you did actually burrow and are currently underground.

Was tested, xenos and thermal equipment (pred masks, bug-b-gone goggles etc.) can still see their health/plasma/rank HUD as before (now just more transparently) and the burrower is still 100% invisible to humans.

Explain why it's good for the game

Improves immersion, fixes a bug (I assume it is considering I've found no PR linked to the change), makes Burrower mains struggle less if they actually burrowed or not

Testing Photographs and Procedure

Screenshots & Videos

video of the "new" feature (actually a fix) in action: https://gachi.gay/u1Ik4

Changelog

🆑Unknownity
fix: Burrowers now see themselves as partly transparent when burrowed.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jun 24, 2024
@TheManWithNoHands
Copy link
Contributor

TheManWithNoHands commented Jun 25, 2024

If i remember rigth there should be a sprite around for the burrower halfway burried. Was for its old straint that was swiftly canned again. If your all about making it more immersive, migth be worth to look into that. Thougth that would be a LOT more work. Just fiy, if you want to dabble with it.

@Unknownity
Copy link
Contributor Author

If i remember rigth there should be a sprite around for the burrower halfway burried. Was for its old straint that was swiftly canned again. If your all about making it more immersive, migth be worth to look into that. Thougth that would be a LOT more work. Just fiy, if you want to dabble with it.

Impaler looks different.

@TheManWithNoHands
Copy link
Contributor

Impaler looks different.

Was just an note in case you didnt know

Copy link
Contributor

github-actions bot commented Jul 8, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 8, 2024
@Zonespace27 Zonespace27 added this pull request to the merge queue Jul 10, 2024
Merged via the queue into cmss13-devs:master with commit 89ba3a6 Jul 10, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jul 10, 2024
@Unknownity Unknownity deleted the BurrowerTransparency branch July 18, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants