Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Upgraded custom incinerator tank" nerf #6564

Closed
wants to merge 1 commit into from

Conversation

kalazus
Copy link

@kalazus kalazus commented Jun 25, 2024

About the pull request

Downgrades flamer_tank/custom/upgraded to flamer_tank/large/X (almost, napalmx has 40 duration instead of 50). Pyro still has even better custom tank.

Explain why it's good for the game

It's too op for non specialists to have 1.5(+fire penetration, +1 range) better fire than roundstart pyro, and same as custom pyro. It is not ok for non specialist to deal about 500 damage (initial setting on fire and 10 second before extinguish) in 1 click of flamer. Also, it makes pyro with custom fuel fully replaceable.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: reduces max intensity and max range of "Upgraded custom incinerator tank".
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jun 25, 2024
@iloveloopers
Copy link
Contributor

At least lower it's price in the biomass machine to be dirt cheap since this nerfs it's main advantage over the free custom tanks printable at OT. The range buff is minimal and duration barely matters at the front where xenos are together and will vomit/pat each other.

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, if you feel they're too plentiful/powerful, increase the cost of them in research and or have them scale faster.

Of note they are still empty tanks so they also need the chemicals in them too to even utilize their increased limits.

@@ -257,10 +257,9 @@
matter = list("metal" = 50) // no free metal
flamer_chem = null
max_rounds = 200
max_range = 7
max_range = 6
fuel_pressure = 1
max_duration = 50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
max_duration = 50
max_duration = 50
max_intensity = 50

Copy link
Author

@kalazus kalazus Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are too powerful, not plentiful (at least haven't seen 3 with it at the same time). It replaces Pyro with research which is no ok. I'm not ok even with napalmx level fire for non specialist (replaces pyro without custom tank), but flamer_tank/custom was added 3 years ago, and wasn't such big of a deal.
What do you mean by "have them scale faster"?
50 with fire penetration is still much better than pyro.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the parameters for

/datum/research_upgrades/item/flamer_tank
name = "Upgraded Incinerator Tank"
desc = "An upgraded incinerator tank, with larger capacity and able to handle stronger fuels."
value_upgrade = 300
clearance_req = 1
change_purchase = 100
minimum_price = 100
maximum_price = 1000
item_reference = /obj/item/ammo_magazine/flamer_tank/custom/upgraded
behavior = RESEARCH_UPGRADE_NULL
upgrade_type = ITEM_ACCESSORY_UPGRADE
/datum/research_upgrades/item/flamer_tank/smoke
name = "Upgraded Incinerator Smoke Tank"
desc = "An upgraded incinerator smoke tank with a larger capacity."
value_upgrade = 100 //not useful enough to be expensive
clearance_req = 1
item_reference = /obj/item/ammo_magazine/flamer_tank/smoke/upgraded
change_purchase = 50
minimum_price = 100
maximum_price = 500

It is currently 300 biomass to produce one, requires the first clearance level, and each print of one increases the cost by 100 biomass, to a max of 1000 biomass.

As far as outclassing pyro, OT/researchers can also give pyro better chems in a /obj/item/ammo_magazine/flamer_tank/custom/large which doesn't need any unlock or has any scaling cost.

Copy link
Contributor

@iloveloopers iloveloopers Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to note that the clearance level is mostly irrelevant as you need clearance 5 anyways to produce a fuel capable of reaching the tank's caps

Copy link
Author

@kalazus kalazus Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have chems you can use tank infinitely (scaling and initial value almost doesnt matter). Also, 300 biomass is nothing for brand new pyro specialist.

@TheManWithNoHands
Copy link
Contributor

TheManWithNoHands commented Jun 26, 2024

Ok, ignoring the fact for a moment that these tanks need to be earnd through killed xenos and arent free.

You do know, that the values your changing are only a cap. They dont change the power of for exampl: napalm in them.
They still need custom fuel, research needs to spend points on, to reach said cap. Or fuel that takes unresonable ammoutn.
Something they where always able to do. And often use for Ot nades.

Like, its very much earned to even be able effectivly used those tanks. If you just pour standart fuel in them there is no change really.

@kalazus
Copy link
Author

kalazus commented Jun 26, 2024

If it will be too garbage with these changes, how about full revert then?
Pyro still has flamer_tank/large/custom to use "much earned" chemicals.

@iloveloopers
Copy link
Contributor

We should probably take this balance discussion into discord but why shouldn't marines get stronger stuff as the round progresses? you're acting as if marines get their hands on this stuff 5 minutes after drop. Theres been about 5 rounds total where strong research flame was at play and they always arrived at the frontlines after 1:20 - 1:30~ hours or after xenos had already hijacked.

@TheManWithNoHands
Copy link
Contributor

If it will be too garbage with these changes, what about full revert then? Pyro still has flamer_tank/large/custom to use "much earned" chemicals.

No, your change is just salt driven. Because, you wanna know a fun thing?
Base m240 OT tanks are capable of using flamer fuel with intensity 40. The intensity of Xfuel. The very thing you said shouldnt be allowed.

Besides that, Research tanks are the fairest thing research can even make. Its the only thing with a combat impact that is finite (cant make infinite more of them once you unlcoked it like chems) are destroyable, rquire a constant influx of new rescources, and cant be automaticly unlocked via stalling. Unlick stims and OT chems, wich can.

@Drulikar Drulikar marked this pull request as draft June 26, 2024 08:08
@Diegoflores31
Copy link
Contributor

The PR has not been UP for more than 2 weeks and you are already asking for a nerf ? I literally never ever seen it on a round since it was merged.

You are basically nerfing a recently approved balance PR with no justification at all.

@Diegoflores31
Copy link
Contributor

We should probably take this balance discussion into discord but why shouldn't marines get stronger stuff as the round progresses?

Bro this dude is just nerfing it for no reason . Upgraded flamer has not even been on the game for 2 weeks and literally never ever seen it used ingame.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 10, 2024
@github-actions github-actions bot closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants