Moves click_adjacent logic to MouseDown #6582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Balance
Doubleumc
reviewed
Jun 29, 2024
Co-authored-by: Doubleumc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Makes it so adjacent clicks are handled on when you press down the button instead of when you press it up
This affects things like pointblanks, melee attacks, picking up items etc etc
Did some testing and fixed things like clicks not working or no click delay melee attacks but there are probably more so it needs to be tested
Explain why it's good for the game
Pointblank wise all of the gun code was already using MouseDown so no reason for pointblanks to stay behind, Other than that this should make adjacent clicks get "eaten" less (since if you too slow to mouse up the click won't be counted) and overall faster reaction time to your actions
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
balance: Adjacent clicks are now registered on mouse down instead of mouse up, this affects pointblanks, melee attacks etc.
/:cl: