Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port WHO to TGUI #6583

Merged
merged 6 commits into from
Jul 21, 2024
Merged

Port WHO to TGUI #6583

merged 6 commits into from
Jul 21, 2024

Conversation

blackcrystall
Copy link
Contributor

@blackcrystall blackcrystall commented Jun 28, 2024 •
edited by github-actions bot
Loading

About the pull request

Just QoL

Explain why it's good for the game

Argghhh. just TGUI new panel? No benefits on round, but for visual and maybe a little bit server, because it don't generate every time for you who list

Changelog

🆑 Blackcrystalic
qol: port who/staffwho to TGUI
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Quality of Life Make the game harder to play labels Jun 28, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 3, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 4, 2024
harryob
harryob requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just this, rest seems alright

code/controllers/subsystem/who.dm Outdated Show resolved Hide resolved
Zonespace27
Zonespace27 previously requested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0001-tgui-who-update.patch

Apply this patch and it should be good to go

@Zonespace27 Zonespace27 marked this pull request as draft July 16, 2024 13:55
@blackcrystall
Copy link
Contributor Author

Done!

@blackcrystall blackcrystall marked this pull request as ready for review July 17, 2024 06:33
@harryob harryob enabled auto-merge July 20, 2024 19:52
@harryob harryob added this pull request to the merge queue Jul 21, 2024
Merged via the queue into cmss13-devs:master with commit 5bc7388 Jul 21, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jul 21, 2024
@cm13-github
Automatic changelog for PR #6583 [ci skip]
d4dcf8a
harryob added a commit that referenced this pull request Jul 23, 2024
@harryob
Revert "Port WHO to TGUI (#6583)"
8653ab2 
This reverts commit 5bc7388.
@harryob harryob mentioned this pull request Jul 23, 2024
Closed
@blackcrystall blackcrystall deleted the tgui_who branch August 13, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryob harryob harryob approved these changes

@Zonespace27 Zonespace27 Zonespace27 left review comments

Assignees
No one assigned
Labels
Quality of Life Make the game harder to play UI deletes nanoui/html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blackcrystall @cm13-github @Zonespace27 @harryob