Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squad roles positions code QoL #6588

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

blackcrystall
Copy link
Contributor

@blackcrystall blackcrystall commented Jun 28, 2024

About the pull request

Small change, to make it a little bit better for any further updates of roles and multi faction gameplay, plus change one letter vars or UPPERCASE names to normal, just a little bit of code formating

Changelog

🆑 BlackCrystalic
code: squads now have lists for roles limit and taken number, not hardcoded role list in vars, plus one letter vars change
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label Jun 28, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 3, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 4, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 12, 2024
@blackcrystall
Copy link
Contributor Author

Again this auto stale system trying to sink review ready pr

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jul 14, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 21, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jul 27, 2024
@Drulikar
Copy link
Contributor

stale exempt until reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Stale Exempt PR can't go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants