-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faction datum rework & statistic battle rating admin and adming game balance info stuff #6589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unreviewably large. Atomize it or talk to the maintainers about getting a project branch for this
This comment has been minimized.
This comment has been minimized.
Yeah, I have troubles with reaching them again, after long break... So, after unban in discord, or I can chat on forum with maintainers/heads Anyway, I'm not running right now this to fast finish & merge, soooo yea |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Okay, I have no idea if this fine and I can continue porting & finishing all that listed in todo... |
PR will be closed for now, no feedback on that (Unable to reach and talk about it with maintainers), so for now I'll stop working on it |
About the pull request
(attempt to port it over №2, after 2 years)
For maintainers: contact me on forum or discord (discord nick as in changelog CL), for addition approving (big features and etc, like statistic, I remember my small talk with Nanu about it long time ago, so yea) or discussions about all stuff in Task section (same, to make it as yall be like to see it), all this code already done, I'm just porting it from my other project and finishing some things (like Actions between factions, faction tasks and some minor contemt for HVH), for me it's fine if something will be denied.
Brand new datums, with module system.
Will be added later more info
WIP (mostly messing with porting stuff, going thru entire game code to be dmed with: Bro, no denied rework)
Tasks
Changelog
🆑 blackcrystalic
add: Brand new factions functional
ui: new TGUI for faction interactions and misc stuff with statistic/rationg
code: Work around faction datums
refactor: Factrions backend
admin: messing with admin stuff, statistic and faction information, balance victory, players relative rating (skill)
/:cl: