Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEA tracking options #6595

Merged
merged 2 commits into from
Jul 6, 2024
Merged

SEA tracking options #6595

merged 2 commits into from
Jul 6, 2024

Conversation

Doubleumc
Copy link
Contributor

@Doubleumc Doubleumc commented Jun 29, 2024

About the pull request

Adds ability to track the CMP.
Adds a SEA headset that can track the CO, XO, and CMP.
Adds handheld crew monitor to SEATech vendor.

image
image

Explain why it's good for the game

Headset tracking is a convenience for SEAs to find command staff. Access to handheld crew monitor is a convenience for SEAs to find people who can't or don't know how to ask for help: namely, privates.

Testing Photographs and Procedure

image
image

Changelog

🆑
imageadd: adds CMP tracker sprites
add: adds a SEA headset, can track CO, XO, CMP
add: adds handheld crew monitor in SEATech vendor
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Jun 29, 2024
@Blundir
Copy link
Contributor

Blundir commented Jun 29, 2024

What about cmo, ce and qm

@Doubleumc
Copy link
Contributor Author

Was only aware of the desire for CMP: image

@Doubleumc Doubleumc changed the title SEA tracking headset SEA tracking options Jun 30, 2024
@Doubleumc
Copy link
Contributor Author

To avoid needing a tracker for every person of interest, I have added access to a handheld crew monitor for the SEA. Will allow them to find anyone, including privates.

@harryob
Copy link
Member

harryob commented Jul 3, 2024

your changelog needs to be complete without context of the add as that's just a symbol in the changelog, so:

add: Adds an SEA headset, can track CO, XO, CMP

@harryob harryob marked this pull request as draft July 3, 2024 17:27
@Doubleumc Doubleumc marked this pull request as ready for review July 3, 2024 20:01
@Doubleumc
Copy link
Contributor Author

Changelog corrected.

@harryob harryob added the Sprites Approved confirmed no stray pixels label Jul 6, 2024
@harryob harryob added this pull request to the merge queue Jul 6, 2024
Merged via the queue into cmss13-devs:master with commit 46a31c9 Jul 6, 2024
32 checks passed
cm13-github added a commit that referenced this pull request Jul 6, 2024
@Doubleumc Doubleumc deleted the sea-tracker-hud branch July 6, 2024 07:44
@Doubleumc Doubleumc mentioned this pull request Jul 9, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 10, 2024
# About the pull request

Fixes CMP tracker icons being incorrect on HUDs other than Midnight:

![image](https://github.com/cmss13-devs/cmss13/assets/14267245/a0c701dc-c5ec-434c-8b76-22fe40e0fc86)

#6595 mistakenly only included
icons for the Midnight HUD. This corrects that omission.

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game

Icons should work across all HUD options.
# Testing Photographs and Procedure
Across all HUDs except "Dark", are duplicates of
#6595 . Shown here for
convenience:

![image](https://github.com/cmss13-devs/cmss13/assets/14267245/1eacd6a8-a37d-4c73-bb59-7f31ab6e2319)

![image](https://github.com/cmss13-devs/cmss13/assets/14267245/ae60cb55-774c-401c-a5a4-ea6331d4f894)

Dark HUD icons are different to match the other Dark HUD trackers:

![image](https://github.com/cmss13-devs/cmss13/assets/14267245/68497394-8620-4a1d-b345-83b7e083d016)

![image](https://github.com/cmss13-devs/cmss13/assets/14267245/c9940e84-f1a7-4f0d-82ed-8634ccb8ad0d)

# Changelog
:cl:
imageadd: adds CMP tracker sprites for all HUD options
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants