Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Non-Toxic Water Stop Glowing #6608

Merged
merged 8 commits into from
Jul 4, 2024

Conversation

Venuska1117
Copy link
Contributor

@Venuska1117 Venuska1117 commented Jul 2, 2024

About the pull request

This PR make non-toxic water stop glowing, it kinda don't make sense, that on some maps, where water cover essential points is just GLOWING, now water will not glow unless its intended to be glowing.

Explain why it's good for the game

Water should not glow in darkness (unless its intended like on trijent dam)

Testing Photographs and Procedure

waterchange-ezgif com-video-to-gif-converter

Changelog

🆑
fix: Make non-toxic water stop glowing.
/:cl:

@Venuska1117 Venuska1117 changed the title Mapping: Make Non-Toxic Water Mapping: Make Non-Toxic Water Stop Glowing Jul 2, 2024
@github-actions github-actions bot added Feature Feature coder badge Fix Fix one bug, make ten more labels Jul 2, 2024
code/game/turfs/floors/desert.dm Show resolved Hide resolved
code/game/turfs/floors/desert.dm Show resolved Hide resolved
code/game/turfs/open.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft July 2, 2024 16:42
@Venuska1117 Venuska1117 requested a review from harryob July 2, 2024 17:22
@Venuska1117 Venuska1117 marked this pull request as ready for review July 2, 2024 18:50
code/game/turfs/open.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft July 3, 2024 17:15
@Venuska1117 Venuska1117 changed the title Mapping: Make Non-Toxic Water Stop Glowing Code: Make Non-Toxic Water Stop Glowing Jul 3, 2024
@Venuska1117 Venuska1117 changed the title Code: Make Non-Toxic Water Stop Glowing Make Non-Toxic Water Stop Glowing Jul 3, 2024
@Venuska1117 Venuska1117 requested a review from harryob July 3, 2024 22:20
@Venuska1117 Venuska1117 marked this pull request as ready for review July 3, 2024 22:20
@harryob harryob added this pull request to the merge queue Jul 4, 2024
Merged via the queue into cmss13-devs:master with commit 3d4be77 Jul 4, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jul 4, 2024
@Venuska1117 Venuska1117 deleted the no-glowing-water branch July 10, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants