Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes to paradropping #6609

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Jul 3, 2024

About the pull request

You cannot get hit by stray bullets, get lit on fire, trigger traps and many more while mid-air.

Explain why it's good for the game

Makes more sense this way.

Testing Photographs and Procedure

I commented out clearing the chute, then tried to shoot past my character, flame my character and teleport my character on top of a resin trap. Flaming still does damage without igniting, but let's assume it's the heat. Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: being mid-paradrop won't trigger traps, fire and stray bullets before you land.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 3, 2024
@harryob harryob marked this pull request as draft July 6, 2024 07:24
@ihatethisengine ihatethisengine marked this pull request as ready for review July 7, 2024 07:38
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 15, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jul 15, 2024
@Zonespace27 Zonespace27 added this pull request to the merge queue Jul 16, 2024
Merged via the queue into cmss13-devs:master with commit 66b4ec3 Jul 16, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants