Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops Queen from stomping on Xenos with relevant pass flags (Lessers/Huggers/Larva) #6618

Closed

Conversation

GrrrKitten
Copy link
Contributor

@GrrrKitten GrrrKitten commented Jul 5, 2024

About the pull request

Stops queen from stomping on Xenos that have relevant pass flags

Also in part fixes an issue that would occasionally cause dancer dodge to flip out

Important notes on this PR:

  • Doesn't stop queen from stomping on xenos on help intent
  • Doesn't stop queen from stomping on resting xenos
  • Doesn't stop queen from stomping on crit xenos
  • Doesn't stop queen from stomping on dancer while in dodge (since that would be a balance change)

Explain why it's good for the game

QoL, just makes sense, prevents the poor baby larvas from getting squarshed

Requested by Venuska1117

Testing Photographs and Procedure

Screenshots & Videos

Don't feel like its necessary

Like the stuff I make?
ko-fi

Changelog

🆑
qol: Stops Queen from stomping on xenos with relevant pass flags (Larva, Hugger, Lesser)
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Jul 5, 2024
@@ -420,6 +420,8 @@
/mob/living/carbon/xenomorph/queen/proc/check_block(mob/queen, turf/new_loc)
SIGNAL_HANDLER
for(var/mob/living/carbon/xenomorph/xeno in new_loc.contents)
if(xeno.pass_flags.flags_pass & PASS_MOB_THRU_XENO|PASS_MOB_THRU &! xeno.flags_pass_temp & PASS_MOB_THRU)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these binary operators look real weird, is &! xeno.flags_pass_temp & PASS_MOB_THRU meant to be resolving as && !(xeno.flags_pass_temp & PASS_MOB_THRU)?

@harryob harryob marked this pull request as draft July 10, 2024 18:37
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 18, 2024
@github-actions github-actions bot closed this Jul 25, 2024
@Drulikar
Copy link
Contributor

Feel free to ask for reopen whenever above can be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants