Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLF Helmet Changes + CLF Breacher for events #6619

Conversation

wshuwshuwshi
Copy link
Contributor

@wshuwshuwshi wshuwshuwshi commented Jul 5, 2024

About the pull request

  • Helmet Changes
    Standard Militia Cowl is no longer conductive, all armor values remained the same
    Militia Bucket helm is conductive, with slightly increased armor values and a vision reduction

  • CLF Breacher
    Creates a CLF breacher for events styled after Ned Kelly
    I fully expect to need to change some of the armor values for the breacher armor, but the intent is for it to be a powerful set of armor which trades visibility and mobility for defense.
    Adds Items
    "Tool Steel Helmet"
    Heavy vision penalty with strong all around defense, applies a small slowdown
    "Tool Steel Panoply"
    Highest preset armor slowdown with strong all around defense
    "Steel Slab"
    New riot shield with a strong active defense, but it applies a slowdown when readied
    Adds HUD Icon for CLF Breachers

Explain why it's good for the game

  • Helmet Changes
    As of right now the Militia Cowl is identical to the bucket helm which just kind of feels wrong.
    Militia Cowl description says it's protective because of the fibers used in its construction, thus it being conductive seems off
    Bucket Helmet feels like it would be a more powerful helmet given the appearance, but it is the exact same

  • CLF Breacher
    More variety is always good, and I feel a 'tank' specialist like this adds a nice contrast to the usually frail but fast CLF

Testing Photographs and Procedure

Screenshots & Videos

https://www.youtube.com/watch?v=e7hkW5HbRcQ

clfb
clfb_helm
riotclfb
riotclfb_l
riotclfb_r
marine_hud

Changelog

🆑
add: CLF Breacher Job Define
add: CLF Breacher HUD Icon
add: CLF Breacher Shield, Armor, and Helmet
balance: Modified CLF helmets. Cowl is no longer conductive, bucket reduces vision but has higher protection
/:cl:

wshuwshuwshi and others added 10 commits July 4, 2024 19:20
Adds Breacher helmet and changes the CLF headgear
Militia Hood is no longer conductive, but keeps its original armor value
Militia Bucket is now conductive, limits vision, and has better armor
Adds the Breacher armor suit
Adds CLF breacher shield
Adds the CLF Breacher skillset
Adds the CLF Breacher equipment preset
allows CLF Breachers to have a unique HUD icon
Adds CLF Breacher to the job define
@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Jul 5, 2024
Bot wanted a comma at the end of the skill list
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 6, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@wshuwshuwshi
Copy link
Contributor Author

Converting to draft until I resolve the .dmi conflict

@wshuwshuwshi wshuwshuwshi marked this pull request as draft July 6, 2024 17:50
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 14, 2024
@github-actions github-actions bot closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Merge Conflict PR can't be merged because it touched too much code Sprites Remove the soul from the game. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants