Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lets xenos drag and drop themselves into a vent crawl #6635

Closed

Conversation

GrrrKitten
Copy link
Contributor

@GrrrKitten GrrrKitten commented Jul 6, 2024

About the pull request

Pt1 of making vents cooler to use

you click ur xeno -> u drag ur mouse while holding m1 -> u drop it on da vent -> badda bing bodda boom ur starting to crawl into da vent

Explain why it's good for the game

QOL, it feels like this is just how it should be, not sure why its not like this already

Testing Photographs and Procedure

Screenshots & Videos

image

image


Like all the cool stuff I make?
ko-fi

Changelog

🆑 Grrr Kitten
qol: xenos can now drag and drop themselves to vent crawl
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Jul 6, 2024
@RainbowStalin
Copy link

Finaly a way to get into vents without using the verbs.

@TheManWithNoHands
Copy link
Contributor

Finaly a way to get into vents without using the verbs.

Verb? Isnt it just alt + M1.

@GrrrKitten
Copy link
Contributor Author

Finaly a way to get into vents without using the verbs.

Verb? Isnt it just alt + M1.

I didn't know this, why must there be so much esoteric knowledge behind dumb binds.

Anyways I'm keeping this up as it doesn't hurt to have more options

/obj/structure/pipes/vents/MouseDrop_T(obj/structure/pipes/vents/dropvent, mob/living/carbon/xenomorph/user)
if(!isxeno(user) || !user.check_state() || !user.can_ventcrawl())
return
if(dropvent in range(1))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(dropvent in range(1))
if(get_dist(src, user) <= 1)

@@ -70,6 +70,12 @@
/obj/structure/pipes/vents/hide()
update_underlays()

/obj/structure/pipes/vents/MouseDrop_T(obj/structure/pipes/vents/dropvent, mob/living/carbon/xenomorph/user)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't dropvent here the atom being dropped (aka the user)?

Suggested change
/obj/structure/pipes/vents/MouseDrop_T(obj/structure/pipes/vents/dropvent, mob/living/carbon/xenomorph/user)
/obj/structure/pipes/vents/MouseDrop_T(atom/dropping, mob/living/carbon/xenomorph/user)

@@ -70,6 +70,12 @@
/obj/structure/pipes/vents/hide()
update_underlays()

/obj/structure/pipes/vents/MouseDrop_T(obj/structure/pipes/vents/dropvent, mob/living/carbon/xenomorph/user)
if(!isxeno(user) || !user.check_state() || !user.can_ventcrawl())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(!isxeno(user) || !user.check_state() || !user.can_ventcrawl())
if(!isxeno(user) || !user.check_state() || !user.can_ventcrawl() || dropping != user)

@harryob harryob marked this pull request as draft July 7, 2024 17:20
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 15, 2024
@github-actions github-actions bot closed this Jul 22, 2024
@Drulikar
Copy link
Contributor

Feel free to ask for reopen when above can be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants