Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elevates InvalidIndexOperation pragma to an error. #6653

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Elevates InvalidIndexOperation pragma to an error. #6653

merged 5 commits into from
Jul 10, 2024

Conversation

Zonespace27
Copy link
Contributor

@Zonespace27 Zonespace27 commented Jul 7, 2024 •
edited by github-actions bot
Loading

About the pull request

Elevates InvalidIndexOperation to be an error in OD compile.

Explain why it's good for the game

image

@Zonespace27 Zonespace27 added the Code Improvement Make the code longer label Jul 7, 2024
@github-actions github-actions bot added the Missing Changelog Maintainers always document their changes. label Jul 7, 2024
@Zonespace27 Zonespace27 requested a review from harryob July 7, 2024 23:22
@Zonespace27 Zonespace27 marked this pull request as draft July 7, 2024 23:22
@Zonespace27 Zonespace27 marked this pull request as ready for review July 8, 2024 06:44
harryob
harryob approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can accept a couple of tasteful operator overloads

@harryob harryob added this pull request to the merge queue Jul 10, 2024
Merged via the queue into cmss13-devs:master with commit 8a06fc0 Jul 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryob harryob harryob approved these changes

Assignees
No one assigned
Labels
Code Improvement Make the code longer Missing Changelog Maintainers always document their changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zonespace27 @harryob @johndoe2013