Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maplint, UpdatePaths, and add new map lints #6656

Merged
merged 23 commits into from
Jul 10, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jul 8, 2024

About the pull request

This PR updates Maplint and UpdatePaths effectively porting these PRs:

New lints:

Also of note, this PR requires: #6654 so that line change is also incorporated in this PR. But I expect this to take a while for mapping review so made a separate PR for it alone that I can just resolve the conflict for here.

Explain why it's good for the game

Prevents issues like this where the center turfs were rotated (reset):
image

Fixes turfs resetting:

turf.mp4

Testing Photographs and Procedure

See https://github.com/cmss13-devs/cmss13/actions/runs/9873200755/job/27264944601#step:7:1187 for an example of the maplint suggestions.

Screenshots & Videos
turf2.mp4

Changelog

🆑 Drathek
maptweak: Removed var edits from open turfs to fix ScrapeAway resetting the turf (e.g. xenos building resin walls) on basically all maps
maptweak: Fixed bad dir var edits on various map
maptweak: Fixed stacked structures on various maps
/:cl:

@Drulikar Drulikar added Work in Progress Will never be finished Tools things to torment players with labels Jul 8, 2024
@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Jul 8, 2024
@Drulikar Drulikar removed the Work in Progress Will never be finished label Jul 10, 2024
@Drulikar Drulikar marked this pull request as ready for review July 10, 2024 15:02
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing looks particularly amiss in the diffs of the maps, python code seems fine. would rather this was merged sooner than later

@harryob harryob added this pull request to the merge queue Jul 10, 2024
Merged via the queue into cmss13-devs:master with commit c415caa Jul 10, 2024
32 checks passed
cm13-github added a commit that referenced this pull request Jul 10, 2024
@Drulikar Drulikar deleted the Update_Maplint branch July 10, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping did you remember to save in tgm format? Tools things to torment players with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants