Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifeboat can now be unhacked by pilot #6661

Merged
merged 28 commits into from
Jul 29, 2024
Merged

Conversation

zzzmike
Copy link
Contributor

@zzzmike zzzmike commented Jul 8, 2024

About the pull request

Similar to how dropships can be unhacked after 3 minutes of pilot interaction, lifeboats now have the same rules.

Explain why it's good for the game

Another cool interaction that might happen once every 100 rounds or so.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: pilots can unhack lifeboats, similar to dropship unhacking
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jul 8, 2024
@ihatethisengine
Copy link
Contributor

I suggest splitting 3 minutes do_after into several smaller ones, look how it's done in dropship unlocking

@zzzmike zzzmike mentioned this pull request Jul 8, 2024
code/modules/shuttle/computer.dm Outdated Show resolved Hide resolved
code/modules/shuttle/computer.dm Show resolved Hide resolved
code/modules/shuttle/computer.dm Outdated Show resolved Hide resolved
code/modules/shuttle/computer.dm Outdated Show resolved Hide resolved
code/modules/shuttle/computer.dm Outdated Show resolved Hide resolved
@zzzmike
Copy link
Contributor Author

zzzmike commented Jul 9, 2024

Sounds good, thanks. I wasn't sure if your progress was intended to be reset or not if you get interrupted, hehe.

code/modules/shuttle/computer.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft July 10, 2024 18:43
@zzzmike zzzmike marked this pull request as ready for review July 10, 2024 21:51
@zzzmike zzzmike requested a review from harryob July 10, 2024 21:55
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 18, 2024
code/modules/shuttle/computer.dm Outdated Show resolved Hide resolved
code/modules/shuttle/computer.dm Outdated Show resolved Hide resolved
code/modules/shuttle/computer.dm Outdated Show resolved Hide resolved
code/modules/shuttle/computer.dm Outdated Show resolved Hide resolved
code/modules/shuttle/computer.dm Outdated Show resolved Hide resolved
code/modules/shuttle/computer.dm Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft July 24, 2024 10:26
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Jul 24, 2024
@zzzmike zzzmike marked this pull request as ready for review July 24, 2024 12:30
@zzzmike zzzmike requested a review from Drulikar July 24, 2024 12:31
code/modules/shuttle/computer.dm Outdated Show resolved Hide resolved
code/modules/shuttle/computer.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft July 29, 2024 15:17
@zzzmike zzzmike marked this pull request as ready for review July 29, 2024 15:44
@zzzmike zzzmike requested a review from Drulikar July 29, 2024 15:54
@Drulikar Drulikar added this pull request to the merge queue Jul 29, 2024
Merged via the queue into cmss13-devs:master with commit 4f9ea4e Jul 29, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jul 29, 2024
@zzzmike zzzmike deleted the patch-5 branch July 29, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants