Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New TWE Warcries #6663

Closed
wants to merge 2 commits into from
Closed

New TWE Warcries #6663

wants to merge 2 commits into from

Conversation

Kyogon
Copy link

@Kyogon Kyogon commented Jul 8, 2024

About the pull request

I felt like the TWE (Royal Marine Commandos) ERT wasn't flavored enough with their stock warcries, despite being painfully bri'ish. I added some warcries for them (for both genders) that should make playing them feel a little more unique.

Yes, I know Sniper is Australian. No, I don't care.

Explain why it's good for the game

GOD SAVE THE QUEEN!!

UPP has custom warcries that make them really stand out from marines, so RP-wise TWE having their own voicelines will enhance immersion and add a little bit of fun to those who get the ERT roll.

Testing Photographs and Procedure

I took a recording of the warcries, and after I was satisfied with the results I realized I was recording in gif form. It works though. It's just a simple code addition that uses the same code the UPP warcries do.

Each gender has two voice matching voice lines.

Changelog

🆑
soundadd: Added unique warcries to TWE ERT
/:cl:

@Kyogon Kyogon requested a review from fira as a code owner July 8, 2024 15:33
@github-actions github-actions bot added the Sound Blast 5 minutes of bass boosted music to our players label Jul 8, 2024
@IroquoisLou
Copy link

Australia is a member state of the TWE, so it makes sense some would sound australian.

@cuberound
Copy link
Contributor

I did read this title as warcrimes several time and hoped for those...

@Valiant1st
Copy link

Australia got nuked.

@Kyogon
Copy link
Author

Kyogon commented Jul 8, 2024

Australia got nuked.

Sniper sounds more british than aussie anyway, so it's fineeeeee

Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sounds don't really fit. The only one that might be salvageable is female 2.

@Zonespace27 Zonespace27 marked this pull request as draft July 8, 2024 18:04
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 16, 2024
@github-actions github-actions bot closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sound Blast 5 minutes of bass boosted music to our players Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants