Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes of gib animation, gib remains, adds new #6668

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

Blundir
Copy link
Contributor

@Blundir Blundir commented Jul 9, 2024

About the pull request

Fixed runner and larva having no gib animation.

Fixed gib remains being broken and invisible, added larva gib remains from old cm repo.

Added gib animation for boiler from TGMC tgstation/TerraGov-Marine-Corps#11908.

Testing Photographs and Procedure

Screenshots & Videos
dreamseeker_BmsbTA1F0p.mp4

Previously there was no gib remains (basically last frame of gib animation, that is a cleanable decal), runner and larva just vanished into thin air while getting gibbed, and boiler had no unique animation, using old queen animation.

This is how gibbing larva or runner without changes in this pr looks like

dreamseeker_GXEmgTxbW9

Changelog

🆑
fix: fixed runner having no gib animation
fix: fixed gib remains being invisible
imageadd: boiler gib animation
imageadd: larva gib remains
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Fix Fix one bug, make ten more labels Jul 9, 2024
@Blundir Blundir changed the title Fixes runner having no gib anitation, adds boiler gib animation Fixes runner having no gib animation, adds boiler gib animation Jul 9, 2024
@Git-Nivrak
Copy link
Contributor

The boiler animation looks wrong if it gets gibbed standing up
And the runner animation looks like something from 2019

@Blundir
Copy link
Contributor Author

Blundir commented Jul 9, 2024

The boiler animation looks wrong if it gets gibbed standing up And the runner animation looks like something from 2019

I don't think he'd be standing by the moment of getting reduced to a puddle, and the runner amination was in the game already, drone uses ancient animation as well, all i did is fix runner having literally nothing.

@Blundir Blundir changed the title Fixes runner having no gib animation, adds boiler gib animation Fixes runner, larva having no gib animation, adds boiler gib animation Jul 9, 2024
@Blundir Blundir changed the title Fixes runner, larva having no gib animation, adds boiler gib animation Fixe of gib animation, gib remains, adds new Jul 9, 2024
@Blundir Blundir changed the title Fixe of gib animation, gib remains, adds new Fixes of gib animation, gib remains, adds new Jul 9, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 18, 2024
@Drulikar Drulikar requested a review from a team July 18, 2024 15:42
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jul 18, 2024
@Drulikar
Copy link
Contributor

Stale exempt until sprite reviewed

Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprites

@nauticall nauticall added Sprites Approved confirmed no stray pixels and removed Stale Exempt PR can't go stale labels Jul 25, 2024
@nauticall nauticall added this pull request to the merge queue Jul 25, 2024
Merged via the queue into cmss13-devs:master with commit 465276f Jul 25, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants