Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthetic Prototype Smartpack Glow Up (IAMTHEGUY EDITION) #6669

Closed

Conversation

QuickLode
Copy link
Contributor

@QuickLode QuickLode commented Jul 9, 2024

About the pull request

Big thanks to iamtheguy for spriting these!
SUPER Resprite Synthetic Smartpack
Adds Dark Blue Synthetic Smartpack
Resprite Dispatcher Uni, WJ Uni, Synth Uni, Old Synth Uni, Janitor Uni), Councilor Uni
Small vendor change(PMC/UPP chooses relevant smartpack colors, adds smartpack & dispatcher back to USCM Synthetic)

Explain why it's good for the game

Up to date sprites which include excellent exoskeleton preference(can be toggled) for visibility. Generally speaking, updating sprites is important to keep aesthetic.

Testing Photographs and Procedure

Tested in a series of 4 rounds to check for bugs, and misplaced pixels.

New Uniforms and Smartpacks image

New Smartpacks
https://cdn.discordapp.com/attachments/777257424590995466/1259490241719435264/image.png?ex=668dd971&is=668c87f1&hm=289930f08f819190205745f66f76d7b2a67d07ea23606930b09af245c3445964&

New Smartpacks onmob back
image

Exoskeletons
https://cdn.discordapp.com/attachments/777257424590995466/1259482307153362985/image.png?ex=668dd20e&is=668c808e&hm=31b04ac872c1ea675b52722bf137aff423ad97fa48a5fcf24c8b45e5b40ad482&

Comparison of before and after (DIFFERENT COLORS)
https://cdn.discordapp.com/attachments/1042176396711170119/1259490343536296006/image.png?ex=668e824a&is=668d30ca&hm=09dfb6007c7fba8f40e5e10f81d22e2ab518f0c28f8b503d0b6dc4c8b5ab660f&

Changelog

🆑
add: Adds darkblue Synthetic Smartpack & dispatcher uniform for Synthetics
imageadd: Adds several BEAUTIFUL Synthetic Smartpack sprites made by iamtheguy, giving a new flair and updated aesthetic.
imageadd: Adds updated WJ uniform, dispatcher uniform, synth uniform, old synth uniform, synth pristine uniform, made by iamtheguy. Old sprites overwritten.
del: limits UPP/PMC Synthetic vendors to choose from relevant smartpacks
del: removes skull balaclavas from synthetics
spellcheck: changes Wey-Yu to Weyland Yutani in smartpack reference, clarifies 'synthetic' prototype smartpack
spellcheck: corrects a typo where surgical cap blue was mentioned twice
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge Removal snap Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Jul 9, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 24, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jul 29, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine

@Drulikar
Copy link
Contributor

Stale exempt until sprite reviewed

@Drulikar Drulikar requested a review from a team July 29, 2024 19:48
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 6, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

@Blundir Blundir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple uniforms resprites are worse than the current ones, multiple backpack colors are off and multiple mistakes with sprite positions. Elaborated on discord.

@Blundir Blundir marked this pull request as draft August 11, 2024 22:11
@QuickLode
Copy link
Contributor Author

Thx, gonna fix this up but not right now I am crazy busy!

@QuickLode QuickLode closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Merge Conflict PR can't be merged because it touched too much code Removal snap Sprites Remove the soul from the game. Stale Exempt PR can't go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants