Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roofs added #6674

Merged
merged 24 commits into from
Jul 14, 2024
Merged

roofs added #6674

merged 24 commits into from
Jul 14, 2024

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Jul 10, 2024

About the pull request

feels strange to add this only as hybrasia behavior, made it into proper structure, it still NEEDS some work. Give me feedback regarding how (and if) it should handle explosions, xeno attack, accid bullets and any other stuff you come up with ( I used catwalk as default sprite as I have no roof sprite, if someone has default roof sprite they could give, go ahead)

Explain why it's good for the game

gives another tool to mappers, it is not exactly ment for covering huge areas with roofs (even tho it works too, might be a bit server heavy tho no idea how it would behave with dozens of mobs constantly moving under roof and being searched for on each mvoement) was made for hybrasia lattices and billboards

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: roof structures added, can be also used for lattices and billboards, go transparent when you are near them
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jul 10, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should also be a way to designate other kinds of objects that go transparent with this group too; e.g. any /obj/structure/prop/hybrisa/billboardsandsigns mounted on the lattices. As far as I can tell they will have the same loc as a lattice.

code/game/objects/structures/roof.dm Outdated Show resolved Hide resolved
code/game/objects/structures/roof.dm Outdated Show resolved Hide resolved
code/game/objects/structures/roof.dm Outdated Show resolved Hide resolved
code/game/objects/structures/roof.dm Outdated Show resolved Hide resolved
code/game/objects/structures/roof.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell everything is working

@Drulikar Drulikar added this pull request to the merge queue Jul 14, 2024
Merged via the queue into cmss13-devs:master with commit f120320 Jul 14, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants