Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made APC's Directional to reduce lines of code, Use and Adds Updatepaths.txt file. #6680

Closed
wants to merge 4 commits into from

Conversation

Venuska1117
Copy link
Contributor

@Venuska1117 Venuska1117 commented Jul 10, 2024

About the pull request

This PR add directional APC's and Updatepath.txt

Explain why it's good for the game

Reduces lines of codes in mapping, i know there is already code in apc.dm to make them have pixel_y or pixel_x offset.

Mainly issue is: in map editor they have var edited offsets, with mean it not only override code that already exist, but also occupy more space, with new code it should do same in exchange for less lines of code. (i didnt remove directional code for other stuff like broken APC's etc.)

Changelog

It do not change anything on maps itself, just replaces paths.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 10, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Venuska1117 Venuska1117 changed the title Made APC's Directional, Use Updatepaths.txt file. Made APC's Directional to reduce lines of code, Use and Adds Updatepaths.txt file. Jul 10, 2024
@github-actions github-actions bot added Mapping did you remember to save in tgm format? Missing Changelog Maintainers always document their changes. labels Jul 10, 2024
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 10, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Venuska1117
Copy link
Contributor Author

the hell

@Venuska1117 Venuska1117 reopened this Jul 10, 2024
@Venuska1117 Venuska1117 deleted the apc-updatepath branch July 11, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping did you remember to save in tgm format? Missing Changelog Maintainers always document their changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants