Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading Lobby Art #6684

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Loading Lobby Art #6684

merged 7 commits into from
Jul 25, 2024

Conversation

blackcrystall
Copy link
Contributor

@blackcrystall blackcrystall commented Jul 11, 2024 •
edited
Loading

About the pull request

Loading around

New icon

(animated, look in vsc/native editor for more info)
image

Changelog

🆑 BlackCrystalic
qol: if server take too long to pre init all before lobby art, players will see lobbyart "loading"
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Quality of Life Make the game harder to play labels Jul 11, 2024
@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Jul 11, 2024
@blackdragonTOW
Copy link
Contributor

Hello! Please remember to attach screenshots of your altered sprites in the PR description!!

@blackcrystall
Copy link
Contributor Author

Added!

Hello! Please remember to attach screenshots of your altered sprites in the PR description!!

Nanu308
Nanu308 previously requested changes Jul 18, 2024
View reviewed changes
maps/map_files/generic/Admin_level.dmm Show resolved Hide resolved
@Nanu308 Nanu308 marked this pull request as draft July 18, 2024 00:53
@blackcrystall blackcrystall marked this pull request as ready for review July 18, 2024 07:18
@harryob
Copy link
Member

harryob commented Jul 18, 2024

Hello! Please remember to attach screenshots of your altered sprites in the PR description!!

this isn't a requirement, image diff bot exists for that

@harryob harryob enabled auto-merge July 18, 2024 07:53
nauticall
nauticall approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shweet

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Jul 25, 2024
@harryob harryob added this pull request to the merge queue Jul 25, 2024
Merged via the queue into cmss13-devs:master with commit 775112b Jul 25, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jul 25, 2024
@cm13-github
Automatic changelog for PR #6684 [ci skip]
d208fe4
@blackcrystall blackcrystall deleted the loaddding branch August 27, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nauticall nauticall nauticall approved these changes

@harryob harryob harryob approved these changes

@Nanu308 Nanu308 Awaiting requested review from Nanu308 Nanu308 is a code owner

Assignees
No one assigned
Labels
Mapping did you remember to save in tgm format? Quality of Life Make the game harder to play Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blackcrystall @blackdragonTOW @harryob @nauticall @Nanu308