Stethoscopes and penlights - An attempt on usefulness (Also, flashlight flashing fixed) #6691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
Zonespace27
previously requested changes
Jul 12, 2024
code/game/machinery/vending/vendor_types/squad_prep/squad_medic.dm
Outdated
Show resolved
Hide resolved
Co-authored-by: Zonespace <[email protected]>
|
Hello! Please remember to attach screenshots of your altered sprites in the PR description!! |
I did add the images, but it seems they are not showing up in github properly |
All showing properly now |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
added
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
kiVts
reviewed
Aug 6, 2024
kiVts
reviewed
Aug 6, 2024
Co-authored-by: kiVts <[email protected]>
kiVts
reviewed
Aug 6, 2024
Co-authored-by: kiVts <[email protected]>
kiVts
requested changes
Aug 6, 2024
…2/CM-Space-Station-13 into Stethoscopes-and-Penlights
|
Late to the party but. can you code so that penlight works inside the helmet. it's effect is similar to rail light |
This was referenced Aug 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
The main purpose of this PR is to add functionality to both the stethoscope and the penlight, with the fixing of the "flash eyes with flashlight" mechanism being only a conterminous addon.
Special thanks to Drathek for assisting with coding this, without his help I wouldn't go anywhere.
Explain why it's good for the game
Adds more detail to the game and allows the player to have more options regarding the diagnosis of their patients. Even though this PR is not meant to replace any type of current diagnosis methods, it is thought to allow the possibility of these items being used if the player wish, or if the situation they are in requires. It is also thought to actually give some purpose to both items, instead of only being decorative (basically).
About the "flash eyes with flashlight" mechanism, it just have been repaired because of its relation with the functionality of the penlight itself. (Remember, only the penlight can be used to do diagnosis, generic flashlights will only allow to temporarily blind the person you are interacting with, and will not give you any medical information).
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑
add: Adds penlights and stethoscopes to nurses and corpsmen, they can use them to reliably check if someone have specific types of organ damage and how much, without the need of other apparatus. Adds a new organ.status called "LITTLE_BRUISED", used by the stethoscope and penlight to not give false positives when diagnosticating someone (saying that they are healthy, when they actually have 9 heart damage).
fix: Fixed an outdated check that made the entire "flash eyes with flashlight" mechanic don't work at all. Also updated it to check some other things for ease of logic.
spellcheck: Fixed typos on the abandoned "flash eyes with flashlight" code.
code: Added new functionalities for both the stethoscope and penlight: The stethoscopes can now be used to check the condition of both heart and lungs individually by aiming the chest, letting you be able to check if the organs are LITTLE_BRUISED (Have a damage equal or above 1), BRUISED (Have a damage equal or above 10), BROKEN (have a damage equal or above 30) or "HEALTHY" (any damage below 1). And the penlight, that can be used the same way to check the condition of brain and eyes by aiming the eyes of the person you are interacting with. Also with the fixing mentioned above, you can now flash people's eyes again! Everytime you check the condition of someone's eyes, you will also flash them. Replaced one letter vars in the flashlight code and on the stethoscope section of the ties code.
imageadd: Adds new "in_hand" icons for penlights and stethoscopes, both will now appear on your hands when used. Penlights have both "off" and "on" icons, fancy stuff!
/:cl: