Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disablers can no longer execute people #6696

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Conversation

zzzmike
Copy link
Contributor

@zzzmike zzzmike commented Jul 12, 2024

About the pull request

Disablers can't execute people anymore.

Explain why it's good for the game

This doesn't really make sense to be in the game, I've never seen anyone intentionally try to execute with a disabler before, it's always some poor newbie MP who does it by accident and gets PTSD afterwards.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
del: Disablers can't execute people anymore
/:cl:

@github-actions github-actions bot added the Removal snap label Jul 12, 2024
@iloveloopers
Copy link
Contributor

Removes soul

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 20, 2024
@zzzmike
Copy link
Contributor Author

zzzmike commented Jul 21, 2024

Removes soul

Erm actually it preserves soul (of the character getting accidentally executed) 🤓

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jul 22, 2024
code/modules/projectiles/guns/energy.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft July 29, 2024 20:29
@zzzmike zzzmike marked this pull request as ready for review July 29, 2024 23:13
@zzzmike
Copy link
Contributor Author

zzzmike commented Jul 29, 2024

thanks, also do you know why the bot removed the stale flag? was it because I made a comment ~20 hours earlier?

@zzzmike zzzmike requested a review from Drulikar July 29, 2024 23:14
@Drulikar
Copy link
Contributor

thanks, also do you know why the bot removed the stale flag? was it because I made a comment ~20 hours earlier?

Yes the stale workflow is just trying to detect inactivity

@Drulikar Drulikar added this pull request to the merge queue Jul 30, 2024
Merged via the queue into cmss13-devs:master with commit 19606df Jul 30, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jul 30, 2024
@zzzmike zzzmike deleted the patch-8 branch July 30, 2024 03:45
@RavinHobo
Copy link

1984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants