Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes ammo box bullet transfer time shorter #6710

Closed

Conversation

private-tristan
Copy link
Contributor

@private-tristan private-tristan commented Jul 15, 2024

About the pull request

Makes the ammo transfer take 1 second instead of 1.5 seconds

Explain why it's good for the game

Slowly transfering bullets is mind numbingly boring, this should make it a little bit better.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: Transfering bullets to/from ammo boxes is now quicker
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Jul 15, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 23, 2024
@Drulikar
Copy link
Contributor

Sorry but the timing is fine. The timing is irrelevant to marines refilling their mags at fob. This timing only matters for those dumping prep, and that already needs more things to discourage it. If I can ever catch up on reviews (seemingly unlikely) req & squads will be using points and I will ensure there's equal access to /obj/item/ammo_box/rounds for req purchase as /obj/item/ammo_box/magazine (if thats not already the case for all applicable types)

@Drulikar Drulikar closed this Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants