Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive research card swiping rework #6714

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jul 15, 2024

About the pull request

This PR revives #6625

Explain why it's good for the game

More intuitive credit reward for research getting a survivor to swipe their card so there isn't a meta strategy for the best utilization of credits. Now at most 47 credits can be awarded (for a manager survivor's card; only allowed to be swiped by them) regardless of whatever the current research clearance is at.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Drathek iloveloopers
del: Removed ability to buy clearance papers.
balance: Clearance cards now give their equivalent clearance in credits.
balance: Clearance cards no longer lose their value when scanned by the wrong person.
/:cl:

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jul 15, 2024
@github-actions github-actions bot added UI deletes nanoui/html Removal snap Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Jul 15, 2024
@Weuyn
Copy link
Contributor

Weuyn commented Jul 15, 2024

50 credits is insane

@Drulikar
Copy link
Contributor Author

50 credits is insane

Review existing code and the credit potential it grants if you were to use it to its maximum potential; it is the same as the values in this PR.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 29, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jul 29, 2024
@harryob harryob added this pull request to the merge queue Aug 5, 2024
Merged via the queue into cmss13-devs:master with commit 5b886ae Aug 5, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Aug 5, 2024
@Drulikar Drulikar deleted the revive_research_card_swiping branch August 5, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Removal snap Stale Exempt PR can't go stale UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants