water particle code cleanup #6721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zonespace27
reviewed
Jul 18, 2024
| // T.firelevel = 0 //TODO: FIX | ||
| if (--src.life < 1) | ||
| //SN src = null | ||
| if (--life < 1) |
There was a problem hiding this comment.
would you mind redoing this so that it doesn't need to use -- before the var it's modifying
|
not shure if I have changed it the way I should but the -- is not used |
Zonespace27
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
removes todo that does not need to be done and renames var
Explain why it's good for the game
eh just a bit cleaner code
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
code: cleans up water particle code
/:cl: