Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scimitar sprite changes #6747

Closed
wants to merge 4 commits into from
Closed

Conversation

JustLat
Copy link
Contributor

@JustLat JustLat commented Jul 18, 2024

About the pull request

This PR changes outdated Yautja sprites in items_lefthand.dmi, items_righthand.dmi, as well as pred_gear.dmi. Specifically, the scimitar sprites alone.

Explain why it's good for the game

Through multiple hours of playing Yautja, the scimitar sprite (north and south states) always looked off-putting to players as well as myself. Instead of a scimitar, they instead looked like metal sticks in both hands of the Yautja. This is just an update of older sprites into refreshed ones that I made myself.

Testing Photographs and Procedure

Screenshots & Videos

scimsouth
scimeast
sciminventory

Changelog

🆑
qol: Updated Yautja scimitar sprites
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Quality of Life Make the game harder to play labels Jul 18, 2024
@Blundir
Copy link
Contributor

Blundir commented Jul 18, 2024

Honestly speaking, current one look absolutely fine, and mob sprite of new ones is drastically worse in sprite quality and looks messy, especially WEST/EAST, also they have completely different color palette for item and mob sprite for some reason.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Aug 2, 2024
@Blundir Blundir removed the Stale beg a maintainer to review your PR label Aug 6, 2024
Copy link
Contributor

@Blundir Blundir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the side sprites and colors, elaborated on discord

@Blundir Blundir marked this pull request as draft August 6, 2024 02:23
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 22, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@JustLat JustLat closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflict PR can't be merged because it touched too much code Quality of Life Make the game harder to play Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants