Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanotrasen to weyland_yutani #6752

Merged
merged 9 commits into from
Aug 1, 2024

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Jul 18, 2024

About the pull request

nanotrasen does not exits we have wy, leaves only one .NuclearBomb__NTIcon {
background-image: url('../assets/bg-nanotrasen.svg');
background-size: 70%;
background-position: center;
background-repeat: no-repeat;
}

Explain why it's good for the game

anothes step away from normal ss13

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: changes references from nanotrasen to weyland yutani
/:cl:

@cuberound cuberound requested a review from Nanu308 as a code owner July 18, 2024 09:26
@github-actions github-actions bot added Mapping did you remember to save in tgm format? Feature Feature coder badge Removal snap UI deletes nanoui/html labels Jul 18, 2024
@BeagleGaming1
Copy link
Contributor

You're messing with save files, you need to add something to update those

@cuberound
Copy link
Contributor Author

You're messing with save files, you need to add something to update those

You're messing with save files, you need to add something to update those

okey should be hopefuly resolved, did not handle this part of code before so double check it please

@efzapa
Copy link
Contributor

efzapa commented Jul 20, 2024

dont forget to rename the centcom berets

the descs are fine, but the name is still CentCom

@cuberound
Copy link
Contributor Author

dont forget to rename the centcom berets

the descs are fine, but the name is still CentCom

future pr perhaps, there is a lot more centcom stuff and I do not know what to rename it to

Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map changes are just filepath changes, lgtm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map changes are just filepath changes, lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Jul 28, 2024
@Drulikar Drulikar changed the title Nanotrasen to weyland_youtani Nanotrasen to weyland_yutani Aug 1, 2024
@Drulikar Drulikar removed Feature Feature coder badge Removal snap labels Aug 1, 2024
@github-actions github-actions bot added the Code Improvement Make the code longer label Aug 1, 2024
@Drulikar Drulikar added this pull request to the merge queue Aug 1, 2024
Merged via the queue into cmss13-devs:master with commit 36c67bd Aug 1, 2024
30 checks passed
cm13-github added a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants