Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elite Mercenary Non-Deathsquad Version #6757

Closed
wants to merge 3 commits into from

Conversation

Steelpoint
Copy link
Contributor

@Steelpoint Steelpoint commented Jul 18, 2024

About the pull request

Alt to: #6740

Adds a new non-Deathsquad varient of the Elite Mercenary ERT.

These mercenaries lack Deathsquad tier armour and Whiteout weapons. Their armour is now akin to Medium Marine armour but with Light movement speed, and they use mostly common or UPP style weapons.

Explain why it's good for the game

Opens up the opportunity for these rarely used ERTs to be used more often for admin events.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: The Elite Mercenary emergency response team has been split into a Deathsquad and non-Deathsquad version. Previously this ERT only functioned with Deathsquad weapons/armour.
admin: The Elite Mercenary Deathsquad version can be denoted with the title of (!DEATHSQUAD!). The non-Deathsquad version possess weapons and armour similar to a typical Marine, albeit they still possess night vision optics.
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Admin Make things harder for admins labels Jul 18, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 26, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 30, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jul 31, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 11, 2024
@@ -662,6 +662,36 @@ GLOBAL_LIST_INIT(rebel_rifles, list(
new_human.equip_to_slot_or_del(new /obj/item/storage/belt/marine, WEAR_WAIST)
spawn_weapon(gunpath, ammopath, M, 0, ammo_amount)

/datum/equipment_preset/proc/spawn_merc_elite_weapon_lowthreat(atom/M, ammo_amount = 12, shotgun_chance = 50, spawn_belt = 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this defined so high up instead of on /datum/equipment_preset/other/elite_merc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also given you're only piping humans into this, you can just type it appropriately

var/gunpath = pick(elite_merc_shotguns)
var/ammopath = elite_merc_shotguns[gunpath]
if(spawn_belt)
if(ishuman(M))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant, type is known

@@ -662,6 +662,36 @@ GLOBAL_LIST_INIT(rebel_rifles, list(
new_human.equip_to_slot_or_del(new /obj/item/storage/belt/marine, WEAR_WAIST)
spawn_weapon(gunpath, ammopath, M, 0, ammo_amount)

/datum/equipment_preset/proc/spawn_merc_elite_weapon_lowthreat(atom/M, ammo_amount = 12, shotgun_chance = 50, spawn_belt = 1)
if(!M) return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no inline control

@harryob harryob marked this pull request as draft August 23, 2024 12:52
@Steelpoint Steelpoint closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants