Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a grab and throw animation + sound #6759

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

Blundir
Copy link
Contributor

@Blundir Blundir commented Jul 18, 2024

About the pull request

Adds small animation and sound when throwing things.

Now grabbing items has the sound and grab visual effect identical to the one when grabbing mobs.

Grabbing items and mobs now has a small animation.

Explain why it's good for the game

More visual clarity is good, also improves immersion.

Testing Photographs and Procedure

Screenshots & Videos
dreamseeker_JVRhGZjBzv.mp4
dreamseeker_eGglKFMztP.mp4

Changelog

🆑
add: grabbing something has a small mob animation now, grabbing items have visual effect, animation and sound
add: throwing has small animation and sound
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jul 18, 2024
@Blundir Blundir changed the title Adds a subtle grab and throw animation + sound Adds a grab and throw animation + sound Jul 18, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 26, 2024
@Drulikar Drulikar marked this pull request as draft July 29, 2024 19:17
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Jul 29, 2024
@Drulikar Drulikar marked this pull request as ready for review July 29, 2024 19:25
@Drulikar Drulikar added this pull request to the merge queue Jul 29, 2024
Merged via the queue into cmss13-devs:master with commit b89cb4d Jul 29, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jul 29, 2024
@Blundir Blundir deleted the animation branch July 29, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants