pick_weight over pickweight #6760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Changelog
lack of "weight" should still count as weight 1
github-actions
bot
added
Code Improvement
Drulikar
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Removes
pickweightand switches over topick_weight. The only difference is thatpickweighttreated weight 0 as weight 1, andpick_weightdoes not. Onlyutility_closetsandflowhad 0-weight entries, and I corrected those.Updates
pick_weightto TG's version, which fixes a statistical error:tgstation/tgstation#71271
tgstation/tgstation#71273
Explain why it's good for the game
Less redundant code. More statistical accuracy.
Testing Photographs and Procedure
Boots.
Changelog
🆑
code: Fixed and refactored probability weighting for pick_weight
/:cl: