-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes M44 revolver rig and SG holster fit any revolver #6761
Conversation
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay; but makes it then a superior mateba holster.
Consider making /obj/item/storage/belt/gun/mateba
7 slots then too (doesn't need to spawn with more ammo, just the slots so theres no reason to dump for a different belt should they care).
# About the pull request M44 revolver belt holster has been renamed to general revolver holster and can now fit any revolver. SG holster belt can now fit any revolver. # Explain why it's good for the game Gun type limitation is very weird and makes very little sense, considering that sidearm pouch can fit literally anything, also general pistol rig can fit any pistol of any design of any faction, so having limitations on revolver belt is very weird and just makes it frustrating in some situations, also makes it easier to create revolver holster belts for corpse spawners/loot/loadouts/etc without creating a billion subtypes with different name and allowed gun. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> ![dreamseeker_pGmOGCrf0m](https://github.com/user-attachments/assets/b4a0df26-5769-4301-a000-147028f17f36) </details> # Changelog :cl: balance: revolver belt and sg holster belt can fit any revolver /:cl:
About the pull request
M44 revolver belt holster has been renamed to general revolver holster and can now fit any revolver.
SG holster belt can now fit any revolver.
Explain why it's good for the game
Gun type limitation is very weird and makes very little sense, considering that sidearm pouch can fit literally anything, also general pistol rig can fit any pistol of any design of any faction, so having limitations on revolver belt is very weird and just makes it frustrating in some situations, also makes it easier to create revolver holster belts for corpse spawners/loot/loadouts/etc without creating a billion subtypes with different name and allowed gun.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑
balance: revolver belt and sg holster belt can fit any revolver
balance: increased mateba belt storage size from 6 to 7
/:cl: