Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes M44 revolver rig and SG holster fit any revolver #6761

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

Blundir
Copy link
Contributor

@Blundir Blundir commented Jul 18, 2024

About the pull request

M44 revolver belt holster has been renamed to general revolver holster and can now fit any revolver.

SG holster belt can now fit any revolver.

Explain why it's good for the game

Gun type limitation is very weird and makes very little sense, considering that sidearm pouch can fit literally anything, also general pistol rig can fit any pistol of any design of any faction, so having limitations on revolver belt is very weird and just makes it frustrating in some situations, also makes it easier to create revolver holster belts for corpse spawners/loot/loadouts/etc without creating a billion subtypes with different name and allowed gun.

Testing Photographs and Procedure

Screenshots & Videos

dreamseeker_pGmOGCrf0m

Changelog

🆑
balance: revolver belt and sg holster belt can fit any revolver
balance: increased mateba belt storage size from 6 to 7
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 18, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 27, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay; but makes it then a superior mateba holster.

Consider making /obj/item/storage/belt/gun/mateba 7 slots then too (doesn't need to spawn with more ammo, just the slots so theres no reason to dump for a different belt should they care).

@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Jul 29, 2024
@Drulikar Drulikar marked this pull request as draft July 29, 2024 18:31
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jul 29, 2024
@Drulikar Drulikar marked this pull request as ready for review July 29, 2024 19:24
@Drulikar Drulikar enabled auto-merge July 29, 2024 19:25
@Drulikar Drulikar added this pull request to the merge queue Jul 29, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 29, 2024
# About the pull request

M44 revolver belt holster has been renamed to general revolver holster
and can now fit any revolver.

SG holster belt can now fit any revolver.

# Explain why it's good for the game

Gun type limitation is very weird and makes very little sense,
considering that sidearm pouch can fit literally anything, also general
pistol rig can fit any pistol of any design of any faction, so having
limitations on revolver belt is very weird and just makes it frustrating
in some situations, also makes it easier to create revolver holster
belts for corpse spawners/loot/loadouts/etc without creating a billion
subtypes with different name and allowed gun.


# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![dreamseeker_pGmOGCrf0m](https://github.com/user-attachments/assets/b4a0df26-5769-4301-a000-147028f17f36)


</details>


# Changelog
:cl:
balance: revolver belt and sg holster belt can fit any revolver
/:cl:
@Drulikar Drulikar removed this pull request from the merge queue due to a manual request Jul 29, 2024
@Drulikar Drulikar added this pull request to the merge queue Jul 29, 2024
Merged via the queue into cmss13-devs:master with commit ac6216d Jul 29, 2024
29 checks passed
cm13-github added a commit that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants