Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes lifeboat launch console being slashable / acidable #6763

Merged
merged 3 commits into from
Jul 21, 2024

Conversation

zzzmike
Copy link
Contributor

@zzzmike zzzmike commented Jul 19, 2024

About the pull request

Lifeboat launch console is clearly meant to not be slashable / acidable (especially since it already has breakable=false flag and the lifepods are already properly flagged unacidable / unslashable. This fixes the problem.

Explain why it's good for the game

Fixes a bug.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: lifeboat launch console is no longer slashable / acidable
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Fix Fix one bug, make ten more labels Jul 19, 2024
@zzzmike
Copy link
Contributor Author

zzzmike commented Jul 19, 2024

(I didn't mean for this to be flagged as feature)

@Drulikar Drulikar removed the Feature Feature coder badge label Jul 19, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also implement the proc ex_act and return (do nothing) since it currently can be destroyed that way too.

@Drulikar Drulikar marked this pull request as draft July 19, 2024 03:09
@zzzmike zzzmike marked this pull request as ready for review July 19, 2024 04:09
@zzzmike
Copy link
Contributor Author

zzzmike commented Jul 19, 2024

thanks :)

@zzzmike zzzmike requested a review from Drulikar July 19, 2024 04:10
@HaultyAnonie
Copy link
Contributor

Why doesn't breakable = FALSE account for all types of damage? What's it used for then?

@Drulikar
Copy link
Contributor

Why doesn't breakable = FALSE account for all types of damage? What's it used for then?

breakable only applies to some structure's implementation of attack_animal and attack_alien But in general there isn't much standardization to defines like breakable, unslashable, unacidable, etc. You just need to look at their references in code to see what they do.

@Drulikar Drulikar added this pull request to the merge queue Jul 21, 2024
Merged via the queue into cmss13-devs:master with commit edc335f Jul 21, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jul 21, 2024
@zzzmike zzzmike deleted the patch-4 branch July 21, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants