Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot join as certain ERTs if you dont have enough relavent playtime. #6764

Merged
merged 10 commits into from
Aug 1, 2024

Conversation

kiVts
Copy link
Contributor

@kiVts kiVts commented Jul 19, 2024

About the pull request

You cannot get foxrot spec ERT if you dont have specialist job unlocked
you cannot get Provost ERT if you dont have 5 hours as MP.

Explain why it's good for the game

For spec, when command buys the spec they're expecting at least some form of gameplay knowledge. Foxrot squad ert already does this, defaulting PVTs to PFC and will not give them engie, etc. Now they cant get it if they couldnt roll it roundstart.

For provost, this beacon (there is another beacon which is without the "ML knowledge required") Will ensure admins can rely on the players to be at least somewhat familiar with MP role.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Players will not get picked at certain ERT beacons if they dont have enough playtime in relevant area.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jul 19, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 27, 2024
code/datums/emergency_calls/cryo_spec.dm Outdated Show resolved Hide resolved
@harryob harryob removed the Stale beg a maintainer to review your PR label Jul 27, 2024
@harryob harryob marked this pull request as draft July 27, 2024 15:50
@kiVts kiVts marked this pull request as ready for review July 27, 2024 22:20
code/datums/emergency_calls/cryo_spec.dm Outdated Show resolved Hide resolved
code/datums/emergency_calls/inspection.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar enabled auto-merge August 1, 2024 08:40
@Drulikar Drulikar added this pull request to the merge queue Aug 1, 2024
Merged via the queue into cmss13-devs:master with commit bf3d9d9 Aug 1, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Aug 1, 2024
@kiVts kiVts deleted the ert_timelock branch August 1, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants