Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts Suppressor Stat Removals #6770

Closed
wants to merge 1 commit into from
Closed

Conversation

challade
Copy link

@challade challade commented Jul 21, 2024

About the pull request

Reverts #3159

Explain why it's good for the game

Reverts the changes done to suppressor.
Although hiding muzzle flash and silencing is nice, it's unfortunate that in most cases this was, and still is, the worse extended barrel.
There's no reason to pick up this attachment. It's become cosmetic. Before, it had downsides and upsides, and was one of a few attachments that added variety, now it's just... filler. Even if it's intended for backliners, why pick this over EB?

(Pardon if I mess up anything in the PR, this is my first time doing a PR by myself)

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: reverts the previous change to the suppressor that removed all stat changes and buffed it's damage fall off (still in the negative).
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 21, 2024
@Drulikar

This comment was marked as resolved.

@Drulikar Drulikar changed the title reverts #3159 Reverts Suppressor Stat Removals Jul 21, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 29, 2024
@Drulikar
Copy link
Contributor

At least for the moment, I don't think this is a change we need. I wasn't keen on it in DMs, and in general it doesn't appear most other people are keen on it either.

@Drulikar Drulikar closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants