Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another NERF to heavy revolver ammo #6775

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Jul 21, 2024

About the pull request

#4706
So this PR replaced knockdown with slow+knockback, but unlike the knockdown proc the slow proc didn't check for the mob size, so you became able to slow down T3s and even Queen with heavy revolver ammo, which clearly wasn't intended. This wasn't noticed until recently.

Explain why it's good for the game

Free slows with no telegraph on T3s is not something we need in the game.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 ihatethisengine2
balance: heavy revolver ammo cannot slowdown t3s anymore.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 21, 2024
@joookschad
Copy link
Contributor

this removes the only good part of heavy revolver ammo

@ihatethisengine
Copy link
Contributor Author

this removes the only good part of heavy revolver ammo

I understand that you are probably joking, but chainslowing T3s with IFF and ZERO telegraph cannot be justified.

code/datums/ammo/ammo.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jul 29, 2024
@Drulikar Drulikar marked this pull request as draft July 29, 2024 20:45
@ihatethisengine ihatethisengine marked this pull request as ready for review July 30, 2024 05:40
code/datums/ammo/ammo.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft July 30, 2024 16:09
@ihatethisengine ihatethisengine marked this pull request as ready for review July 31, 2024 04:13
@Drulikar Drulikar added this pull request to the merge queue Aug 1, 2024
@Drulikar
Copy link
Contributor

Drulikar commented Aug 1, 2024

Feel free to tweak slugs for consistency. Also I will note that predaliens are tier 1 so will be slowed still.

Merged via the queue into cmss13-devs:master with commit 4cf38fa Aug 1, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants