Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap/orbit icons resprite and remake #6791

Merged
merged 13 commits into from
Oct 27, 2024
Merged

Conversation

Blundir
Copy link
Contributor

@Blundir Blundir commented Jul 25, 2024

About the pull request

Visually redoes how minimap and orbit icons look.

The ones that were redone look like this (old ones on the right, new ones on the left)

image

Adds support and new icons for all factions that have special huds, adds yautja unique icons, all icons for jobs that lack it, so on.

All sprites by me.

Explain why it's good for the game

Current icons are very hard to tell apart, especially orbit icons, some colors are extremely off, orbit icons do not utilize backgrounds at all (it's just plain color fill), also some things there aren't working correctly at all, resulting in many icons being gray mess (shipside)

Here is an example of current icons:

image

image

hTH7SC46jJ

U3hYykHC7u

I overhaul them to looks something like this

chrome_4IcDecN80W

image

image

PYlGchbRLX

Testing Photographs and Procedure

3SCyS7VqhF

vNWh6gJtUV

gXkkL9QxGG

dreammaker_2SkTzjlmAW

dreammaker_zmQ9lWMm3B

Changelog

🆑
add: minimap icons for all factions, roles, etc
code: tweaked how icons are assembled, added support for custom icon background on equipment preset
imageadd: added a lot of new minimap icons
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. UI deletes nanoui/html Feature Feature coder badge Code Improvement Make the code longer labels Jul 25, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 30, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Oct 27, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Oct 27, 2024
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Oct 27, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Blundir Blundir removed the Stale beg a maintainer to review your PR label Oct 27, 2024
@Blundir Blundir marked this pull request as ready for review October 27, 2024 14:55
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the typescript error

tgui/packages/tgui/interfaces/Orbit/index.tsx Outdated Show resolved Hide resolved
@harryob harryob added the Sprites Approved confirmed no stray pixels label Oct 27, 2024
@harryob harryob added this pull request to the merge queue Oct 27, 2024
Merged via the queue into cmss13-devs:master with commit 5d255af Oct 27, 2024
27 checks passed
cmss13-ci bot added a commit that referenced this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game. UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants