Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new male scream #6806

Closed
wants to merge 2 commits into from
Closed

new male scream #6806

wants to merge 2 commits into from

Conversation

halworsen
Copy link

@halworsen halworsen commented Jul 27, 2024

About the pull request

what it says on the tin

Explain why it's good for the game

cool new scream 👍

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added a new male scream
/:cl:

@halworsen halworsen requested a review from fira as a code owner July 27, 2024 14:19
@github-actions github-actions bot added Sound Blast 5 minutes of bass boosted music to our players Feature Feature coder badge labels Jul 27, 2024
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please state the sound's source and any applicable licensing

@halworsen
Copy link
Author

Taken from Apollo station but the file metadata suggests it's from the Johnson Brand Editing SFX Library.

I can't find the original source anymore (probably a dead free SFX site) but judging by this SFX pack with the same name by the same author (which contains many other iconic SS13 scream SFX), it's very likely a CC0 license.

@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 5, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 5, 2024
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scream is noticeably different than the rest of our scream noises. What to fix:

  • The sound is fairly quiet in comparison to the others
  • It sounds far further away from the microphone than the others
  • It has reverb that the others lack

@Zonespace27 Zonespace27 marked this pull request as draft August 21, 2024 00:44
@harryob
Copy link
Member

harryob commented Oct 8, 2024

pr appears to be stale, feel free to make a new pr addressing the requested changes

@harryob harryob closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sound Blast 5 minutes of bass boosted music to our players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants