Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can use russian warcry if you know russian #6816

Closed
wants to merge 1 commit into from

Conversation

Blundir
Copy link
Contributor

@Blundir Blundir commented Jul 29, 2024

About the pull request

Warcry now checks for the current default language selected instead of faction, so knowing russian you can yell russian warcries, can probably be expanded to other languages later.

dreamseeker_vUC9dJQ8j2.mp4

Basically copypaste of chunk from this RU-CMSS13#225

Explain why it's good for the game

It just logically makes sense, also solves cases where UPP survivors or UPP background roles couldn't use the proper warcries which was very awkward.

Changelog

🆑
add: russian warcries can be used if russian language is set on default
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jul 29, 2024
@ihatethisengine
Copy link
Contributor

For survs it makes sense, for marines I am not so sure.

@Blundir
Copy link
Contributor Author

Blundir commented Jul 29, 2024

For survs it makes sense, for marines I am not so sure.

Majority of people have english on default all of the time, not that many people even have custom languages, also there is tons of ethnically justified characters that should be able to do it, so i see no problem with it whatsoever

@Skatuk
Copy link

Skatuk commented Jul 30, 2024

Speedmerge pls

@Noname995
Copy link
Contributor

Cool feature :)

@Zonespace27
Copy link
Contributor

While I do think it makes sense, I'm against this as it takes away some of the uniqueness of the UPP (plus I know it'll cause marines to take russian to be dumb with warcries)

@Blundir
Copy link
Contributor Author

Blundir commented Aug 12, 2024

While I do think it makes sense, I'm against this as it takes away some of the uniqueness of the UPP (plus I know it'll cause marines to take russian to be dumb with warcries)

Then at least make sure that all upp roles (especially survs) have the upp faction for them

@Zonespace27
Copy link
Contributor

Then at least make sure that all upp roles (especially survs) have the upp faction for them

I'd be fine with this, yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants