Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes grab and throw animation + sound #6826

Closed
wants to merge 1 commit into from

Conversation

Tsurupeta
Copy link
Contributor

@Tsurupeta Tsurupeta commented Jul 30, 2024

About the pull request

Removes small animation and sound when throwing things.

Grabbing items will no longer have the sound and grab visual effect identical to the one when grabbing mobs.

Grabbing items and mobs will no longer have a small animation.

Explain why it's good for the game

The "new" sounds and animations look bad and are irritating. The audiovisual clutter and random sounds when you're just equipping yourself in prep room do not improve immersion and serve no point. The "disarm" sound on throw makes you think that someone is fighting, when in reality John Private has just thrown an ointment from his first aid pouch in the prep room.

Changelog

🆑
del: Removed item grabbing/throwing mob animations and sounds.
/:cl:

@github-actions github-actions bot added the Removal snap label Jul 30, 2024
@Blundir
Copy link
Contributor

Blundir commented Jul 30, 2024

Not a nice move considering you could've just contancted me, and not a nice move twice since nobody had a problem with grab one and you just did lazy way and made revert instead of manual edit.

@Tsurupeta
Copy link
Contributor Author

Tsurupeta commented Jul 30, 2024

Not a nice move considering you could've just contancted me

I don't know how to contact you.

and not a nice move twice since nobody had a problem with grab one and you just did lazy way and made revert instead of manual edit.

I have. What's the point in manual removal of 8 lines, if reverting does the exact same thing?

My main issue is that this thing was just merged without any testing or feedback. I throw a lot of shit just because i'm used to throwing rather than dropping stuff, and hearing an overly loud "disarm.ogg" sound when you're just throwing empty mag or something is IRRITATING AS HELL. Also, hearing "grab.ogg" sound when someone literally pulls and item nearby is also EXTREMELY IRRITATING.

Those sounds should not be shared, because grabbing mob is much more important to know than pulling an item. Same goes for throwing. This having same sound for both actions makes you confused in what's happening.

Also when someone throws knife into fence, you now hear 5 sounds in the span of 1 second instead of just 3.

@Blundir
Copy link
Contributor

Blundir commented Jul 30, 2024

I don't know how to contact you.

I'm on cm discord all the time

I have. What's the point in manual removal of 8 lines, if reverting does the exact same thing?

Nobody had issue with the other part of the pr, but you just removed it completely.

Also the exact same thing that i did was made on tg, aurora, onyxbay and many others, and nobody had a problem with it for years, it's just some people having rejection from anything new, the two issues with what i made, the volume and the sound file, were already addressed and i was about to tweak it anyway.

@Tsurupeta
Copy link
Contributor Author

Tsurupeta commented Jul 30, 2024

I'm on cm discord all the time

I'm not.

Nobody had issue with the other part of the pr, but you just removed it completely.

I had.

Also the exact same thing that i did was made on tg, aurora, onyxbay and many others, and nobody had a problem with it for years

You can't really compare CM to /tg/, aurora or onyxbay.

the two issues with what i made, the volume and the sound file, were already addressed and i was about to tweak it anyway.

I have no way of knowing what's going on inside your head. I saw a problem and proposed a viable solution. Since I don't want to make my own sounds, it's much easier to remove the problematic thing rather than wait for you to fix it.

@Drulikar
Copy link
Contributor

Feel free to tweak the animations or find different sounds to address any concerns; but merely reversion is not going to be accepted.

@Drulikar Drulikar closed this Jul 30, 2024
@Skatuk

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants