Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes duplicating items with vendors #6844

Closed
wants to merge 6 commits into from

Conversation

VileBeggar
Copy link
Contributor

@VileBeggar VileBeggar commented Aug 1, 2024

About the pull request

stops players from being able to duplicate items with vendors
fixes #6475

Explain why it's good for the game

bugs are bad. i don't think this bug actually resulted in much of a benefit because the glitched items were very buggy

Testing Photographs and Procedure

Screenshots & Videos

tested restocking items from the inventory too, and it works

Attachment.Ifx.mp4

Changelog

🆑
fix: You can no longer duplicate items with vendors.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Aug 1, 2024
@Drulikar Drulikar marked this pull request as draft August 1, 2024 15:48
@VileBeggar VileBeggar marked this pull request as ready for review August 2, 2024 17:03
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really a solution to the cited bug because you can still say tactical reload a mag into the vendor, and then its free ammo. Try instead preventing vendor restock if the user is busy instead.

However, restocking guns maybe shouldn't be a thing regardless unless attachments are restored to their stock state. So disabling guns going back into the vendor is okay unless you want to perform additional checks on the gun to ensure it is in its stock state.

@Drulikar Drulikar marked this pull request as draft August 4, 2024 03:38
@VileBeggar VileBeggar closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weapon attachments and some other items can be duplicated
2 participants