Fullscreen improvements #6850
Merged
Fullscreen improvements #6850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Feature
harryob
requested changes
Aug 23, 2024
There was a problem hiding this comment.
we don't really like these helpers - they were incidentally ported at some point before tg removed them (tgstation/tgstation#49106) and we should do the same
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
remove dangling parenthesis
harryob
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Added a toggle fullscreen key, default F11.
Switched to
is-fullscreenimplementation, which preserves window size/maximized from before fullscreening. The previousis-maximizeddisable/enable dance was to avoid a BYOND issue with fullscreening a maximized window. That issue was resolved in 515.1639: https://www.byond.com/forum/post/2924219Fullscreen now hides the menu bar.
Toggling fullscreen now triggers adaptive zoom and/or auto viewport resize if those are enabled.
Renamed the proc to
update_fullscreensince that part wasn't actually toggling anything.Explain why it's good for the game
Testing Photographs and Procedure
Boots without issue. Preference is toggled and preserved. Fullscreening while maximized works properly on version 1639 and above. Non-fullscreened screen state is preserved.
Changelog
🆑
add: Added toggle fullscreen hotkey, default F11
qol: fullscreening hides the menu bar
fix: toggling fullscreen preserves your non-fullscreened window options
/:cl: