Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen improvements #6850

Merged
merged 4 commits into from
Aug 24, 2024
Merged

Conversation

Doubleumc
Copy link
Contributor

@Doubleumc Doubleumc commented Aug 2, 2024

About the pull request

Added a toggle fullscreen key, default F11.

Switched to is-fullscreen implementation, which preserves window size/maximized from before fullscreening. The previous is-maximized disable/enable dance was to avoid a BYOND issue with fullscreening a maximized window. That issue was resolved in 515.1639: https://www.byond.com/forum/post/2924219

Fullscreen now hides the menu bar.

Toggling fullscreen now triggers adaptive zoom and/or auto viewport resize if those are enabled.

Renamed the proc to update_fullscreen since that part wasn't actually toggling anything.

Explain why it's good for the game

Testing Photographs and Procedure

Boots without issue. Preference is toggled and preserved. Fullscreening while maximized works properly on version 1639 and above. Non-fullscreened screen state is preserved.

Changelog

🆑
add: Added toggle fullscreen hotkey, default F11
qol: fullscreening hides the menu bar
fix: toggling fullscreen preserves your non-fullscreened window options
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Quality of Life Make the game harder to play Fix Fix one bug, make ten more labels Aug 2, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't really like these helpers - they were incidentally ported at some point before tg removed them (tgstation/tgstation#49106) and we should do the same

code/modules/client/client_procs.dm Outdated Show resolved Hide resolved
code/modules/client/preferences_toggles.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft August 23, 2024 09:30
@Doubleumc Doubleumc marked this pull request as ready for review August 23, 2024 18:42
@Doubleumc Doubleumc requested a review from harryob August 23, 2024 18:43
@harryob harryob added this pull request to the merge queue Aug 24, 2024
Merged via the queue into cmss13-devs:master with commit 13682c3 Aug 24, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Aug 24, 2024
@Doubleumc Doubleumc deleted the fullscreen-improvements branch August 24, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants