Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop phones from going in lockers/crates #6856

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

VileBeggar
Copy link
Contributor

@VileBeggar VileBeggar commented Aug 2, 2024

About the pull request

stops phones from going in lockers/crates, which prevents players from exploiting the phone drag feature.
fixes #6201

i tried making it so the phones would bust out of the crate, but it would look really odd as reset_tether() would get called and the phone would magically teleported and become attached to the backpack. i couldn't find a way to make it smoothly pop out of the crate, and i think this is a decent enough alternative, as i don't know if a single situation where a player would need to store a phone.

this also stops the phone tether from becoming destroyed if you put it in an anchored closet.

Explain why it's good for the game

fixes a (funny) exploit and another niche issue

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

locker.fix.mp4

Changelog

🆑
fix: Phones can no longer be stored in closets/crates, which prevents players from dragging crates with their phones and other weird issues that can occur.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Aug 2, 2024
@Drulikar Drulikar added this pull request to the merge queue Aug 4, 2024
Merged via the queue into cmss13-devs:master with commit 5962257 Aug 4, 2024
29 checks passed
cm13-github added a commit that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phone Dragging Crate
2 participants