Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardises unmeltable SG & Specialist Gear, and removes the (now-legacy) SG kit from req. #6893

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

BasilHerb
Copy link
Contributor

@BasilHerb BasilHerb commented Aug 7, 2024

About the pull request

This PR makes the M56 Combat Harness & the M45 Ghillie Suit unmeltable, and removes the $10K SG kit from requisitions, now that there is no need for SGs to buy it if their shit gets melted.

The purpose of this PR is to standardise the ongoing trend of unmeltable unique marine gear, and serves to patch up the stragglers that were left behind during the initial un-meltification of specialist & SG equipment.

I have tested all my changes- I can confirm the SG kit is no longer in req, and that you can no longer melt the M56 Combat Harness, nor the M45 Ghillie Suit. I have also tested for any spec kits that are still meltable, and found none (besides the sniper, which I fixed.)

Explain why it's good for the game

The pain of losing your unique gear to Young Drone (XX-420) while your fellow protagonists have unmeltable gear is well-felt across the playerbase. John Marine strips your ass of your gear to defib you on the frontline, the xenos overrun your position, you go back to retrieve it, but it's been melted to shit because a sentinel took the 0.5 microseconds needed to melt it down. Congrats. You rolled SG, and you are now useless, because whilst your gun is unmeltable, for some strange reason your armour isn't.
If you're the sniper, it sucks a bit less since you don't need the armour to fire your gun- But still, you've lost your sweet camo armour and are now dripless.

I removed the SG kit from req because it's useless now, plus no one used it anyways because it costs 10K (and also Drathek told me to)

Testing Photographs and Procedure

Screenshot 2024-08-07 144616
(The SG kit has been thanos snapped from req)
Screenshot 2024-08-07 143618
(The M45 Ghillie Suit is no longer meltable now, despite what the image says)

Changelog

🆑
del: removed the M56B Smartgun Kit from requisitions.
balance: made the M56 Combat Harness unmeltable.
balance: made the M45 Ghillie Suit unmeltable.
/:cl:

@github-actions github-actions bot added the Missing Changelog Maintainers always document their changes. label Aug 7, 2024
@github-actions github-actions bot added Removal snap Balance You need to be a professional veteran game maintainer to comprehend what is being done here. and removed Missing Changelog Maintainers always document their changes. labels Aug 7, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Aug 7, 2024
@private-tristan
Copy link
Contributor

The SG gear kit still is needed because FORECON SG, despite getting harness and SG, doesn't get NVGs/extended view range.

@TheManWithNoHands
Copy link
Contributor

Buying the SG kit isnt about it getting melted. Dont forget it has automag harness. Its about losing it after you got stripped.
Also, that you can buy the kit aint hurting anybody. No reason to remove it, when it cant cause damage staying in.
Also, there is currently a PR up thats trying to add SPEC weapons to ASRS console.
Cause it aint about them getting melted, its about them getting lost and left behind enemy lines.

@Unknownity
Copy link
Contributor

Keep the kit in req, you never know what could happen.

@Drulikar
Copy link
Contributor

Drulikar commented Aug 8, 2024

What pr is adding spec weapons to asrs? It's not #6694 (commits) (originally it was). I would rather marines then make a group to recover important weapons if they're going to be unmeltable. Otherwise if you want them purchase able, they should be meltable; but I think needing them to be recovered is more interesting.

@Drulikar Drulikar added this pull request to the merge queue Aug 9, 2024
Merged via the queue into cmss13-devs:master with commit 7b79377 Aug 9, 2024
30 checks passed
cm13-github added a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Removal snap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants